st2chatops also may need proxies #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Makes sense 👍
Thanks for the contribution!
looks like lower-case http_proxy and https_proxy should work well according to slackapi/hubot-slack#372 (comment)
arm4b
reviewed
Apr 8, 2019
| @@ -10,7 +10,7 @@ | |||
| # NB: Empty ENV var cast to 'None' string in Ansible | |||
| state: "{{ 'present' if ansible_facts.env.get(item.1, 'None') != 'None' else 'absent' }}" | |||
| vars: | |||
| _services: [st2api, st2actionrunner] | |||
| _services: [st2api, st2actionrunner, st2chatops] | |||
There was a problem hiding this comment.
After looking closer, this addition should belong to st2chatops Ansible role as it could be installed separately.
Would be great to move it from StackStorm.st2 to StackStorm.st2chatops instead.
There was a problem hiding this comment.
Ok, how can we do this when this one has already been merged?
There was a problem hiding this comment.
Just open another PR that adds to st2chatops and removes from st2
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it can't connect to RTM on Slack, for example.